Server side language headers#1981
Merged
tdonohue merged 2 commits intoDSpace:mainfrom Dec 16, 2022
Merged
Conversation
tdonohue
approved these changes
Dec 16, 2022
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @YanaDePauw ! The code looks good to me & I've verified it has no side effects that I can see.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
This PR fixes the issue with the browser languages not being added to the Accept-Language header for server side requests.
Instructions for Reviewers
Reproducing this issue requires inspecting the "Accept-Language" header of server side calls which aren't visible in the network tab of a browser.
The easiest way to achieve this is to hook a backend you can debug to the angular application and then debug the incoming calls and compare the headers from the server side calls and the client side calls.
An example on how to do this is the following:
SiteRestRepositoryon the first line of thefindOnemethod.getRequestService().getCurrentRequest().getHttpServletRequest().getHeader("user-agent");node.jsin the value.getRequestService().getCurrentRequest().getHttpServletRequest().getHeader("Accept-Language");getRequestService().getCurrentRequest().getHttpServletRequest().getHeader("user-agent");node.jsin the value.getRequestService().getCurrentRequest().getHttpServletRequest().getHeader("Accept-Language");Checklist
yarn run lintpackage.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.